When Refactoring Makes Code Worse

return LastOrderInfoBuilder() .withCreationDate(creationDate) .withRegion(region) .withPaymentType(paymentType) .withDeliveryType(deliveryType) .withAddress(address) .withOutletId(id) .build() return [[[[[[[[[lastOrderInfoBuilder new] withCreationDate:creationDate] withRegion:region] withPaymentType:paymentType] withDeliveryType:deliveryType] withDeliveryDate:deliveryDate] withTimeInterval:deliveryInterval] withAddress:address] withOutletId:outletId] withBuyerInfo:buyerInfo] build];

A clean, readable builder-style code snippet is shown on the left, while an absurdly nested and difficult-to-read version appears on the right. The joke is that an attempt to improve or transform the code has made it dramatically worse, like an unflattering FaceApp transformation. It is shared as a reaction to overengineering, bad refactoring, or ugly generated code.

• @profunctor_io / 2671 2019-07-19